LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/clone-before-after-content-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/clone-before-after-content-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/before-child-anonymous-column-block-expected.html ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/clone-before-after-content-crash-expected.txt » ('j') | LayoutTests/fast/multicol/span/adjacent-spanners.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <style>	3 <style>

4 #test1 { -webkit-column-count: 1; }	4 #test1 { -webkit-column-count: 1; }

5 #test2 { display: block; }	5 #test2 { display: block; }

6 #test3::after { display: block; content: "A"; }	6 #test3::after { display: block; content: "A"; }

7 #test4 { -webkit-column-span: all; }	7 #test4 { -webkit-column-span: all; }

8 </style>	8 </style>

9 <script>	9 <script>

	10 if (window.internals)

	11 internals.settings.setRegionBasedColumnsEnabled(true);

10 if (window.testRunner)	12 if (window.testRunner)

11 testRunner.dumpAsText();	13 testRunner.dumpAsText();

12 function runTest(){	14 function runTest(){

13 test1 = document.createElement('div');	15 test1 = document.createElement('div');

14 test1.setAttribute('id', 'test1');	16 test1.setAttribute('id', 'test1');

15 document.body.appendChild(test1);	17 document.body.appendChild(test1);

16 test2 = document.createElement('div');	18 test2 = document.createElement('div');

17 test2.setAttribute('id', 'test2');	19 test2.setAttribute('id', 'test2');

18 test1.appendChild(test2);	20 test1.appendChild(test2);

19 test3 = document.createElement('div');	21 test3 = document.createElement('div');

20 test3.setAttribute('id', 'test3');	22 test3.setAttribute('id', 'test3');

21 test2.appendChild(test3);	23 test2.appendChild(test3);

22 test4 = document.createElement('span');	24 test4 = document.createElement('span');

23 test4.setAttribute('id', 'test4');	25 test4.setAttribute('id', 'test4');

24 test3.appendChild(test4);	26 test3.appendChild(test4);

25 document.body.offsetTop;	27 document.body.offsetTop;

26 test4.style.display='block';	28 test4.style.display='block';

27 }	29 }

28 window.onload = runTest	30 window.onload = runTest

29 </script>	31 </script>

30 </head>	32 </head>

31 <body>	33 <body>

32 Test passes if it does not crash.	34 Test passes if it does not crash.

33 </body>	35 </body>

34 </html>	36 </html>

OLD	NEW