Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 296413004: Remove high promotion mode. (Closed)

Created:
6 years, 7 months ago by Hannes Payer (out of office)
Modified:
6 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -306 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -23 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +1 line, -22 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/execution.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap.h View 1 3 chunks +4 lines, -70 lines 0 comments Download
M src/heap.cc View 7 chunks +3 lines, -72 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -20 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -22 lines 0 comments Download
M src/serialize.cc View 1 chunk +9 lines, -14 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -22 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +1 line, -20 lines 0 comments Download
M test/cctest/test-heap.cc View 4 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
6 years, 7 months ago (2014-05-26 12:26:16 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/296413004/diff/1/src/heap.h File src/heap.h (right): https://codereview.chromium.org/296413004/diff/1/src/heap.h#newcode2028 src/heap.h:2028: bool IsHighSurvivalRate() { As discussed offline: Can we ...
6 years, 7 months ago (2014-05-26 12:47:33 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/296413004/diff/1/src/heap.h File src/heap.h (right): https://codereview.chromium.org/296413004/diff/1/src/heap.h#newcode2028 src/heap.h:2028: bool IsHighSurvivalRate() { On 2014/05/26 12:47:33, Michael Starzinger wrote: ...
6 years, 7 months ago (2014-05-26 12:57:39 UTC) #3
Hannes Payer (out of office)
6 years, 7 months ago (2014-05-26 12:59:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21493 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698