Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2964113004: Revert "Added for-loop variable tracking and regular closures/initializers captured variable tracki… (Closed)

Created:
3 years, 5 months ago by Emily Fortuna
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Added for-loop variable tracking and regular closures/initializers captured variable tracking." I think I had a bad merge. Reverting to figure out the issue. This reverts commit d40f84fbf8fbe13ab37a62959ec20a924bd82d88. BUG= Committed: https://github.com/dart-lang/sdk/commit/b6671a0e3f6904edc1a1aa787fc8a13bce95436f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -536 lines) Patch
M pkg/compiler/lib/src/closure.dart View 8 chunks +25 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure.dart View 4 chunks +88 lines, -179 lines 0 comments Download
D pkg/compiler/lib/src/js_model/closure_visitors.dart View 1 chunk +0 lines, -278 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 2 chunks +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 6 chunks +15 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/closure/closure_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/forloop_box_test.dart View 3 chunks +5 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Emily Fortuna
TBR. Bad merge. Will try again in a bit.... :-(
3 years, 5 months ago (2017-07-01 14:33:33 UTC) #2
Emily Fortuna
3 years, 5 months ago (2017-07-01 14:34:02 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b6671a0e3f6904edc1a1aa787fc8a13bce95436f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698