Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: services/resource_coordinator/coordination_unit/coordination_unit_impl.h

Issue 2964103002: [GRC] Decouple Render Process CPU Measurement from CU Graph (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/coordination_unit/coordination_unit_impl.h
diff --git a/services/resource_coordinator/coordination_unit/coordination_unit_impl.h b/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
index 2e69cc80ecb0b5b9f59affa9ad5b71d6fb9297b5..ba4020b3f99d918473399d0595df85cc7ed16daa 100644
--- a/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
+++ b/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
@@ -56,8 +56,7 @@ class CoordinationUnitImpl : public mojom::CoordinationUnit {
// Recalculate property internally.
virtual void RecalculateProperty(mojom::PropertyType property) {}
- // Propagate property change to relevant |CoordinationUnitImpl| instances
- // by invoking their their |RecalculateProperty|.
+ // Propagate property change to relevant |CoordinationUnitImpl| instances.
virtual void PropagateProperty(mojom::PropertyType property) {}
// Overridden from mojom::CoordinationUnit:
@@ -69,11 +68,15 @@ class CoordinationUnitImpl : public mojom::CoordinationUnit {
void SetCoordinationPolicyCallback(
mojom::CoordinationPolicyCallbackPtr callback) override;
void SetProperty(mojom::PropertyPtr property) override;
+ void SetPropertyAndPropagate(mojom::PropertyPtr property) override;
Zhen Wang 2017/07/05 15:37:50 Rebase the CL on lpy's CL for this.
// Operations performed on the internal key-value store.
void ClearProperty(mojom::PropertyType property);
base::Value GetProperty(mojom::PropertyType property) const;
void SetProperty(mojom::PropertyType property, base::Value value);
+ // Set property on internal key-value store and trigger children to
+ // know the value has changed.
+ void SetPropertyAndPropagate(mojom::PropertyType property, base::Value value);
// Methods utilized by the |CoordinationUnitGraphObserver| framework.
void WillBeDestroyed();

Powered by Google App Engine
This is Rietveld 408576698