Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2964043004: Run dartdevc tests on drt instead of Chrome on the bots. (Closed)

Created:
3 years, 5 months ago by Bob Nystrom
Modified:
3 years, 5 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, zra
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run dartdevc tests on drt instead of Chrome on the bots. Also, do another triage pass on the tests. R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/1bd907dc2e22ba10a8a98493076e887363afa57e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -62 lines) Patch
M tests/corelib_strong/corelib_strong.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language_strong/language_strong.status View 1 chunk +7 lines, -10 lines 0 comments Download
M tests/lib_strong/lib_strong.status View 2 chunks +3 lines, -49 lines 0 comments Download
M tools/bots/ddc_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/configuration.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 5 months ago (2017-06-29 23:32:04 UTC) #2
vsm
lgtm
3 years, 5 months ago (2017-06-30 15:22:43 UTC) #3
Bob Nystrom
3 years, 5 months ago (2017-07-05 16:45:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1bd907dc2e22ba10a8a98493076e887363afa57e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698