Support double-tap to click in touch accessibility controller.

ui/chromeos/touch_exploration_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/chromeos/touch_exploration_controller.h"
 
 #include "base/time/time.h"
 #include "ui/aura/client/cursor_client.h"
 #include "ui/aura/test/aura_test_base.h"
 #include "ui/aura/test/event_generator.h"
@@ skipping 137 matching lines @@
 
 // TODO(mfomitchev): Need to investigate why we don't get mouse enter/exit
 // events when running these tests as part of ui_unittests. We do get them when
 // the tests are run as part of ash unit tests.
 
 // Simple test to confirm one-finger touches are transformed into mouse moves.
 TEST_F(TouchExplorationTest, OneFingerTouch) {
   SwitchTouchExplorationMode(true);
   cursor_client()->ShowCursor();
   cursor_client()->DisableMouseEvents();
+
   aura::test::EventGenerator generator(root_window());
-  gfx::Point location_start = generator.current_location();
-  gfx::Point location_end(11, 12);
+  gfx::Point location_start(11, 12);
+  gfx::Point location_end(13, 14);
+  generator.set_current_location(location_start);
+  generator.set_simulated_time(base::TimeDelta::FromMilliseconds(1000));
   generator.PressTouch();
+  EXPECT_FALSE(IsInTouchToMouseMode());
+
+  generator.set_simulated_time(base::TimeDelta::FromMilliseconds(2000));
+  generator.MoveTouch(location_end);
   EXPECT_TRUE(IsInTouchToMouseMode());

[mfomitchev, 2014/05/28 17:47:45]

Can we move this check up before the move?

[dmazzoni, 2014/05/31 06:53:24]

Yes, that makes sense. To do that I had to create an abstraction for advancing
time and faking calling the tap timer. It's able to assert that the timer was
started and then stop it afterwards, so that seems safe and appropriate for a
unit test.

-  generator.MoveTouch(location_end);
+
   // Confirm the actual mouse moves are unaffected.
+  gfx::Point location_real_mouse_move(13, 14);
   ui::MouseEvent mouse_move(ui::ET_MOUSE_MOVED,
-                            gfx::Point(13, 14),
-                            gfx::Point(13, 14),
+                            location_real_mouse_move,
+                            location_real_mouse_move,
                             0,
                             0);
   generator.Dispatch(&mouse_move);
   generator.ReleaseTouch();
 
   const ScopedVector<ui::LocatedEvent>& captured_events = GetCapturedEvents();
   ScopedVector<ui::LocatedEvent>::const_iterator it;
   // TODO(mfomitchev): mouse enter/exit events
   int num_mouse_moves = 0;
   for (it = captured_events.begin(); it != captured_events.end(); ++it) {
     int type = (*it)->type();
     // Ignore enter and exit mouse events synthesized when the mouse cursor is
     // shown or hidden.
     if (type == ui::ET_MOUSE_ENTERED || type == ui::ET_MOUSE_EXITED)
       continue;
     EXPECT_EQ(ui::ET_MOUSE_MOVED, (*it)->type());
-    if (num_mouse_moves == 0)
-      EXPECT_EQ(location_start, (*it)->location());
-    if (num_mouse_moves == 1 || num_mouse_moves == 3)
+
+    if (num_mouse_moves == 0) {

[mfomitchev, 2014/05/28 17:47:45]

I think there should be a synthesized mouse move after the grace period expires
and then another one for the touch move, and possibly another one for the
release.

[dmazzoni, 2014/05/31 06:53:24]

Agreed, you see all of those now.

(The one for the release was missing because the coordinates of the "real" mouse
move were the same. If you make the "real" mouse move go to a different
location, then the touch release fires one more fake mouse move.

       EXPECT_EQ(location_end, (*it)->location());
-    if (num_mouse_moves == 2)
-      CONFIRM_EVENTS_ARE_MOUSE_AND_EQUAL(*it, &mouse_move);
-    if (num_mouse_moves != 2) {
       EXPECT_TRUE((*it)->flags() & ui::EF_IS_SYNTHESIZED);
       EXPECT_TRUE((*it)->flags() & ui::EF_FROM_TOUCH);
     }
+    if (num_mouse_moves == 1) {
+      EXPECT_EQ(location_real_mouse_move, (*it)->location());
+      CONFIRM_EVENTS_ARE_MOUSE_AND_EQUAL(*it, &mouse_move);
+    }
+
     num_mouse_moves++;
   }
-  EXPECT_EQ(4, num_mouse_moves);
+  EXPECT_EQ(2, num_mouse_moves);
 }
 
 // Turn the touch exploration mode on in the middle of the touch gesture.
 // Confirm that events from the finger which was touching when the mode was
 // turned on don't get rewritten.
 TEST_F(TouchExplorationTest, TurnOnMidTouch) {
   SwitchTouchExplorationMode(false);
   cursor_client()->ShowCursor();
   cursor_client()->DisableMouseEvents();
   aura::test::EventGenerator generator(root_window());
@@ skipping 243 matching lines @@
   for (it = captured_events.begin(); it != captured_events.end(); ++it) {
     if ((*it)->type() == ui::ET_MOUSE_MOVED) {
       EXPECT_EQ(touch3_location, (*it)->location());
       break;
     }
   }
   EXPECT_NE(captured_events.end(), it);
 }
 
 }  // namespace ui