Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 296403010: Pepper: Remove Plugin::StreamAsFile. (Closed)

Created:
6 years, 7 months ago by teravest
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Remove Plugin::StreamAsFile. This method isn't necessary any longer. This is a small change to clean up more of the OpenManifestEntry logic and move it out of the trusted plugin. BUG=239656 R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273034

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M ppapi/native_client/src/trusted/plugin/plugin.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/service_runtime.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
teravest
6 years, 7 months ago (2014-05-27 19:24:21 UTC) #1
dmichael (off chromium)
lgtm
6 years, 7 months ago (2014-05-27 20:44:20 UTC) #2
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 7 months ago (2014-05-27 20:46:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/296403010/20001
6 years, 7 months ago (2014-05-27 20:48:22 UTC) #4
teravest
6 years, 7 months ago (2014-05-27 21:20:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r273034 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698