Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 296403008: [Telemetry] When JS times out, output everything in |this|. (Closed)

Created:
6 years, 7 months ago by tonyg
Modified:
6 years, 7 months ago
Reviewers:
achuithb, dtu, shadi
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry] When JS times out, output everything in |this|. This should make timeouts more actionable. BUG=370668 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M tools/telemetry/telemetry/core/web_contents.py View 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
tonyg
6 years, 7 months ago (2014-05-27 16:46:43 UTC) #1
achuithb
lgtm
6 years, 7 months ago (2014-05-27 17:33:55 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 7 months ago (2014-05-27 17:35:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/296403008/1
6 years, 7 months ago (2014-05-27 17:36:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 20:58:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 21:58:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/157322)
6 years, 7 months ago (2014-05-27 21:58:10 UTC) #7
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 7 months ago (2014-05-27 21:59:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/296403008/1
6 years, 7 months ago (2014-05-27 22:01:14 UTC) #9
dtu
Unit test? Doesn't EvaluateJavaScript run in the top-level context, so |this| is always window?
6 years, 7 months ago (2014-05-27 22:09:26 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 23:05:19 UTC) #11
commit-bot: I haz the power
Change committed as 273090
6 years, 7 months ago (2014-05-28 00:34:40 UTC) #12
tonyg
6 years, 7 months ago (2014-05-28 00:41:03 UTC) #13
Message was sent while issue was closed. 
On 2014/05/27 22:09:26, dtu wrote:
> Unit test?

Instrumented by testLoopWaitForLoopTimeout.

> Doesn't EvaluateJavaScript run in the top-level context, so |this| is always
window?

Yes. But there's still useful stuff in there. If you have ideas how to get more
info, plmk or post patch.

Powered by Google App Engine
This is Rietveld 408576698