Implement type variables on generalized function types.

Implement type variables on generalized function types.

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/3fd7bd1bdc90430f63d5f40d5d56f40eaa914dd1

[ahe, 2017-06-29 14:31:41]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, paulberry@google.com

[ahe, 2017-06-29 14:31:41]

Florian: If you won't mind, could you check if this fixes your problems with the
Zone patch?

[Paul Berry, 2017-06-29 17:45:40]

lgtm

https://codereview.chromium.org/2964013002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2964013002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:2965: List<TypeParameter>
typeParameters = new List<TypeParameter>.filled(
Nit: why not use map()?

https://codereview.chromium.org/2964013002/diff/1/pkg/front_end/testcases/str...
File pkg/front_end/testcases/strong.status (right):

https://codereview.chromium.org/2964013002/diff/1/pkg/front_end/testcases/str...
pkg/front_end/testcases/strong.status:64:
inference/downwards_inference_on_generic_function_expressions: Fail
Feel free to put `# TODO(paulberry)` here if you want.  I'll get to work on it
ASAP.

[Paul Berry, 2017-06-30 03:02:22]

https://codereview.chromium.org/2964013002/diff/1/pkg/front_end/testcases/str...
File pkg/front_end/testcases/strong.status (right):

https://codereview.chromium.org/2964013002/diff/1/pkg/front_end/testcases/str...
pkg/front_end/testcases/strong.status:64:
inference/downwards_inference_on_generic_function_expressions: Fail
On 2017/06/29 17:45:40, Paul Berry wrote:
> Feel free to put `# TODO(paulberry)` here if you want.  I'll get to work on it
> ASAP.

I have a fix ready to send out as soon as you land this CL

[ahe, 2017-07-04 11:07:45]

Thank you, Paul!

https://codereview.chromium.org/2964013002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2964013002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:2965: List<TypeParameter>
typeParameters = new List<TypeParameter>.filled(
On 2017/06/29 17:45:40, Paul Berry wrote:
> Nit: why not use map()?

I try to avoid methods like that because they aren't optimized as well as one
would hope.

https://codereview.chromium.org/2964013002/diff/1/pkg/front_end/testcases/str...
File pkg/front_end/testcases/strong.status (right):

https://codereview.chromium.org/2964013002/diff/1/pkg/front_end/testcases/str...
pkg/front_end/testcases/strong.status:64:
inference/downwards_inference_on_generic_function_expressions: Fail
On 2017/06/29 17:45:40, Paul Berry wrote:
> Feel free to put `# TODO(paulberry)` here if you want.  I'll get to work on it
> ASAP.

Done.

https://codereview.chromium.org/2964013002/diff/1/pkg/front_end/testcases/str...
pkg/front_end/testcases/strong.status:64:
inference/downwards_inference_on_generic_function_expressions: Fail
On 2017/06/30 03:02:22, Paul Berry wrote:
> On 2017/06/29 17:45:40, Paul Berry wrote:
> > Feel free to put `# TODO(paulberry)` here if you want.  I'll get to work on
it
> > ASAP.
> 
> I have a fix ready to send out as soon as you land this CL

Acknowledged.

[ahe, 2017-07-04 11:29:29]

Description was changed from

==========
Implement type variables on generalized function types.
==========

to

==========
Implement type variables on generalized function types.

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3fd7bd1bdc90430f63d5f40d5d56f40eaa914dd1
==========

[ahe, 2017-07-04 11:29:30]

Committed patchset #2 (id:20001) manually as
3fd7bd1bdc90430f63d5f40d5d56f40eaa914dd1 (presubmit successful).