Issue 2964003: Make kCookiePromptExpanded a profile pref rather than a local state pref so it can be synced.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2964003: Make kCookiePromptExpanded a profile pref rather than a local state pref so it can be synced. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by skrul

Modified:
4 years ago

Reviewers:
sky

CC:
chromium-reviews, Raghu Simha, ncarter, idana, timsteele, ben+cc_chromium.org

Visibility:
Public.

Make kCookiePromptExpanded a profile pref rather than a local state pref so it can be synced. BUG=40483 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52142

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -21 lines)			Patch
M	chrome/browser/browser_prefs.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/cookie_modal_dialog.h	View	1	4 chunks	+14 lines, -1 line	0 comments	Download
M	chrome/browser/cookie_modal_dialog.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cookie_modal_dialog_gtk.cc	View	1	3 chunks	+10 lines, -13 lines	0 comments	Download
M	chrome/browser/sync/glue/synchronized_preferences.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/views/cookie_prompt_view.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/cookie_prompt_view.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download

Trybot results: win

Total messages: 2 (0 generated)

LGTM