Further splitting of inference type-info

Further splitting of inference type-info

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/ee04f3dc5f414bd8cda4451e680a084ffbc75cdf

[Johnni Winther, 2017-06-29 16:51:01]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-29 21:24:50]

lgtm

https://codereview.chromium.org/2963983002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right):

https://codereview.chromium.org/2963983002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:1809: //
'LocalFunctionElement.callMethod' is used as key for
at that point, would we even have a ClosureTypeInformatin? Woudln't the .call
method just be a method?

https://codereview.chromium.org/2963983002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_system.dart (right):

https://codereview.chromium.org/2963983002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_system.dart:435: TypeInformation
allocateClosureForMethod(
+dartdoc here and above?

I'm not sure about the two names here and their intent. Seeing the use sites it
seems to me that the above is really about creating closures associated with
function expressions and local function declarations, and this one here comes
from a tear-off of a method for a constant. Is that correct?

[Johnni Winther, 2017-06-30 07:52:26]

Description was changed from

==========
Further splitting of inference type-info
==========

to

==========
Further splitting of inference type-info

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ee04f3dc5f414bd8cda4451e680a084ffbc75cdf
==========

[Johnni Winther, 2017-06-30 07:52:28]

Committed patchset #3 (id:40001) manually as
ee04f3dc5f414bd8cda4451e680a084ffbc75cdf (presubmit successful).

[Johnni Winther, 2017-06-30 07:55:31]

https://codereview.chromium.org/2963983002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right):

https://codereview.chromium.org/2963983002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:1809: //
'LocalFunctionElement.callMethod' is used as key for
On 2017/06/29 21:24:49, Siggi Cherem (dart-lang) wrote:
> at that point, would we even have a ClosureTypeInformatin? Woudln't the .call
> method just be a method?

ClosureTypeInformation is (as far as I can see) used for multiple purposes...

https://codereview.chromium.org/2963983002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_system.dart (right):

https://codereview.chromium.org/2963983002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_system.dart:435: TypeInformation
allocateClosureForMethod(
On 2017/06/29 21:24:49, Siggi Cherem (dart-lang) wrote:
> +dartdoc here and above?
> 
> I'm not sure about the two names here and their intent. Seeing the use sites
it
> seems to me that the above is really about creating closures associated with
> function expressions and local function declarations, and this one here comes
> from a tear-off of a method for a constant. Is that correct?
> 

That is my understanding, too.