Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 296393007: [Android] Fix the issue of muted attribute in video element does not work. (Closed)

Created:
6 years, 7 months ago by Shouqun
Modified:
6 years, 7 months ago
Reviewers:
qinmin
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Fix the issue of muted attribute in video element does not work. SetVolume is called before the media player bridge is created, so the volume(muted) is not set correctly. BUG=377737 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273160

Patch Set 1 #

Total comments: 1

Patch Set 2 : update the CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M media/base/android/media_player_bridge.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/android/media_player_bridge.cc View 1 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Shouqun
6 years, 7 months ago (2014-05-27 14:11:42 UTC) #1
Shouqun
6 years, 7 months ago (2014-05-27 14:11:43 UTC) #2
qinmin
https://codereview.chromium.org/296393007/diff/1/media/base/android/media_player_bridge.cc File media/base/android/media_player_bridge.cc (right): https://codereview.chromium.org/296393007/diff/1/media/base/android/media_player_bridge.cc#newcode327 media/base/android/media_player_bridge.cc:327: Prepare(); The player could get destroyed if releaseMediaResources is ...
6 years, 7 months ago (2014-05-27 15:09:53 UTC) #3
Shouqun
On 2014/05/27 15:09:53, qinmin wrote: > https://codereview.chromium.org/296393007/diff/1/media/base/android/media_player_bridge.cc > File media/base/android/media_player_bridge.cc (right): > > https://codereview.chromium.org/296393007/diff/1/media/base/android/media_player_bridge.cc#newcode327 > ...
6 years, 7 months ago (2014-05-28 00:55:43 UTC) #4
qinmin
lgtm
6 years, 7 months ago (2014-05-28 01:15:09 UTC) #5
Shouqun
The CQ bit was checked by shouqun@chromium.org
6 years, 7 months ago (2014-05-28 01:19:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun@chromium.org/296393007/20001
6 years, 7 months ago (2014-05-28 01:22:18 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 05:38:49 UTC) #8
Message was sent while issue was closed.
Change committed as 273160

Powered by Google App Engine
This is Rietveld 408576698