Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 296393003: Revert of linux_aura: Add Trusty libappindicator. (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of linux_aura: Add Trusty libappindicator. (https://codereview.chromium.org/297833013/) Reason for revert: Suspected for waterfall failures "gsignal.c:2459: signal `insert' is invalid" also possibly some obscure ASAN/LSAN errors http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%20%28dbg%29%282%29&number=46389 http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2531 [15124:15124:0524/063846:FATAL:browser_main_loop.cc(205)] GLib-GObject: /build/buildd/glib2.0-2.32.4/./gobject/gsignal.c:2459: signal `insert' is invalid for instance `0xcb71d63c0b0' #0 0x7f91f99d3019 base::debug::StackTrace::StackTrace() #1 0x7f91f9a4f139 logging::LogMessage::~LogMessage() #2 0x7f920330e20d content::(anonymous namespace)::GLibLogHandler() #3 0x7f91f3ab0f61 g_logv #4 0x7f91f3ab1172 g_log #5 0x7f91f3d7dd47 g_signal_connect_data #6 0x7f91d9293efb <unknown> #7 0x7f91d9294e8e <unknown> #8 0x7f91d92961a8 dbusmenu_gtk_parse_menu_structure #9 0x7f91d96af8fe app_indicator_set_menu #10 0x7f91f8ac609b libgtk2ui::AppIndicatorIcon::SetMenu() #11 0x7f91f8ac5e3a libgtk2ui::AppIndicatorIcon::SetImageFromFile() #12 0x7f91f8ac92c8 base::internal::RunnableAdapter<>::Run() ==7567==ERROR: AddressSanitizer: heap-use-after-free on address 0x60800001e028 at pc 0x4cfb688 bp 0x7f4facffd2d0 sp 0x7f4facffd2c8 WRITE of size 4 at 0x60800001e028 thread T7 (CompositorRaste) ==14726==ERROR: LeakSanitizer: detected memory leaks Direct leak of 116 byte(s) in 2 object(s) allocated from: #0 0x5758ab in __interceptor_malloc /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75 #1 0x7f52ed561a38 in g_malloc /build/buildd/glib2.0-2.32.4/./glib/gmem.c:159 Original issue's description: > linux_aura: Add Trusty libappindicator. > > BUG=374686 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272718 TBR=pkotwicz@chromium.org,erg@chromium.org NOTREECHECKS=true NOTRY=true BUG=374686 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/ui/libgtk2ui/app_indicator_icon.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of linux_aura: Add Trusty libappindicator.
6 years, 7 months ago (2014-05-26 00:07:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/296393003/1
6 years, 7 months ago (2014-05-26 00:07:52 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 00:09:08 UTC) #3
Message was sent while issue was closed.
Change committed as 272763

Powered by Google App Engine
This is Rietveld 408576698