Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Side by Side Diff: components/omnibox/browser/titled_url_match_utils.cc

Issue 2963883002: Omnibox UI Experiments: Refactor HTTPS trimming into UrlFormatter. (Closed)
Patch Set: fix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/omnibox/browser/titled_url_match_utils.h" 5 #include "components/omnibox/browser/titled_url_match_utils.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "components/bookmarks/browser/titled_url_node.h" 9 #include "components/bookmarks/browser/titled_url_node.h"
10 #include "components/omnibox/browser/autocomplete_match.h" 10 #include "components/omnibox/browser/autocomplete_match.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 const bool trim_http = 78 const bool trim_http =
79 !AutocompleteInput::HasHTTPScheme(input.text()) && 79 !AutocompleteInput::HasHTTPScheme(input.text()) &&
80 ((match_start == base::string16::npos) || (match_start != 0)); 80 ((match_start == base::string16::npos) || (match_start != 0));
81 std::vector<size_t> offsets = TitledUrlMatch::OffsetsFromMatchPositions( 81 std::vector<size_t> offsets = TitledUrlMatch::OffsetsFromMatchPositions(
82 titled_url_match.url_match_positions); 82 titled_url_match.url_match_positions);
83 // In addition to knowing how |offsets| is transformed, we need to know how 83 // In addition to knowing how |offsets| is transformed, we need to know how
84 // |inline_autocomplete_offset| is transformed. We add it to the end of 84 // |inline_autocomplete_offset| is transformed. We add it to the end of
85 // |offsets|, compute how everything is transformed, then remove it from the 85 // |offsets|, compute how everything is transformed, then remove it from the
86 // end. 86 // end.
87 offsets.push_back(inline_autocomplete_offset); 87 offsets.push_back(inline_autocomplete_offset);
88 match.contents = AutocompleteMatch::FormatUrlForSuggestionDisplayWithOffsets( 88 auto format_types = AutocompleteMatch::GetFormatTypes(trim_http);
89 url, trim_http, &offsets); 89 match.contents = url_formatter::FormatUrlWithOffsets(
90 url, format_types, net::UnescapeRule::SPACES, nullptr, nullptr, &offsets);
90 inline_autocomplete_offset = offsets.back(); 91 inline_autocomplete_offset = offsets.back();
91 offsets.pop_back(); 92 offsets.pop_back();
92 TitledUrlMatch::MatchPositions new_url_match_positions = 93 TitledUrlMatch::MatchPositions new_url_match_positions =
93 TitledUrlMatch::ReplaceOffsetsInMatchPositions( 94 TitledUrlMatch::ReplaceOffsetsInMatchPositions(
94 titled_url_match.url_match_positions, offsets); 95 titled_url_match.url_match_positions, offsets);
95 match.contents_class = ClassificationsFromMatchPositions( 96 match.contents_class = ClassificationsFromMatchPositions(
96 new_url_match_positions, match.contents.size(), true); 97 new_url_match_positions, match.contents.size(), true);
97 match.fill_into_edit = 98 match.fill_into_edit =
98 AutocompleteInput::FormattedStringWithEquivalentMeaning( 99 AutocompleteInput::FormattedStringWithEquivalentMeaning(
99 url, match.contents, scheme_classifier); 100 url, match.contents, scheme_classifier);
(...skipping 27 matching lines...) Expand all
127 return; 128 return;
128 for (TitledUrlMatch::MatchPositions::iterator it = 129 for (TitledUrlMatch::MatchPositions::iterator it =
129 title_match_positions->begin(); 130 title_match_positions->begin();
130 it != title_match_positions->end(); ++it) { 131 it != title_match_positions->end(); ++it) {
131 it->first -= leading_whitespace_chars; 132 it->first -= leading_whitespace_chars;
132 it->second -= leading_whitespace_chars; 133 it->second -= leading_whitespace_chars;
133 } 134 }
134 } 135 }
135 136
136 } // namespace bookmarks 137 } // namespace bookmarks
OLDNEW
« no previous file with comments | « components/omnibox/browser/history_url_provider.cc ('k') | components/omnibox/browser/zero_suggest_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698