Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2963833002: More fixes for missing interface targets when not in strong mode. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More fixes for missing interface targets when not in strong mode. In my previous CL, I only addressed method invocation targets. This CL addresses getter and setter interface targets. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c99f11cf8074ff0799ea26938a6f7479f1f997c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -161 lines) Patch
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 2 chunks +12 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_super.dart.direct.expect View 1 chunk +14 lines, -14 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_super_upwards.dart.direct.expect View 3 chunks +28 lines, -28 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000012.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/super_rasta_copy.dart.direct.expect View 2 chunks +114 lines, -114 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-06-28 18:26:03 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-28 18:33:16 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-28 19:21:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c99f11cf8074ff0799ea26938a6f7479f1f997c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698