ui/gfx/font_render_params_win.cc - Issue 2963783002: Remove unsafe registry APIs from base::win::RegKey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/font_render_params_win.cc

Issue 2963783002: Remove unsafe registry APIs from base::win::RegKey

Patch Set: half-fix remoting Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/font_render_params_win.cc

diff --git a/ui/gfx/font_render_params_win.cc b/ui/gfx/font_render_params_win.cc

index 1f8ab84c8448d9e0cd8a75f665406f088ddbbbc7..f2ac9f43c28ce73754e3916e957bde9411bc5b82 100644

--- a/ui/gfx/font_render_params_win.cc

+++ b/ui/gfx/font_render_params_win.cc

@@ -31,8 +31,8 @@ FontRenderParams::SubpixelRendering GetSubpixelRenderingGeometry() {

(L"SOFTWARE\\Microsoft\\Avalon.Graphics\\" + trimmed.value()).c_str(),

KEY_READ);

DWORD pixel_structure;

- if (key.ReadValueDW(L"PixelStructure", &pixel_structure) ==

- ERROR_SUCCESS) {

+ if (key.Valid() && key.ReadValueDW(L"PixelStructure", &pixel_structure) ==

+ ERROR_SUCCESS) {

if (pixel_structure == 1)

return FontRenderParams::SUBPIXEL_RENDERING_RGB;

if (pixel_structure == 2)