Remove unsafe registry APIs from base::win::RegKey

base/win/registry.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_WIN_REGISTRY_H_
 #define BASE_WIN_REGISTRY_H_
 
 #include <windows.h>
 #include <stdint.h>
 #include <string>
@@ skipping 15 matching lines @@
 //  * ReadValue family of functions guarantee that the out-parameter
 //    is not touched in case of failure.
 //  * Functions returning LONG indicate success as ERROR_SUCCESS or an
 //    error as a (non-zero) win32 error code.
 class BASE_EXPORT RegKey {
  public:
   // Called from the MessageLoop when the key changes.
   typedef base::Callback<void()> ChangeCallback;
 
   RegKey();
-  explicit RegKey(HKEY key);
+  explicit RegKey(HKEY rootkey);
   RegKey(HKEY rootkey, const wchar_t* subkey, REGSAM access);
   ~RegKey();
 
+  RegKey(RegKey&&);
+  RegKey& operator=(RegKey&&);
+
   LONG Create(HKEY rootkey, const wchar_t* subkey, REGSAM access);
 
   LONG CreateWithDisposition(HKEY rootkey, const wchar_t* subkey,
                              DWORD* disposition, REGSAM access);
 
   // Creates a subkey or open it if it already exists.
   LONG CreateKey(const wchar_t* name, REGSAM access);
 
   // Opens an existing reg key.
   LONG Open(HKEY rootkey, const wchar_t* subkey, REGSAM access);
 
   // Opens an existing reg key, given the relative key name.
   LONG OpenKey(const wchar_t* relative_key_name, REGSAM access);
 
   // Closes this reg key.
   void Close();
 
-  // Replaces the handle of the registry key and takes ownership of the handle.
-  void Set(HKEY key);
-
-  // Transfers ownership away from this object.
-  HKEY Take();
-
   // Returns false if this key does not have the specified value, or if an error
   // occurrs while attempting to access it.
   bool HasValue(const wchar_t* value_name) const;
 
   // Returns the number of values for this key, or 0 if the number cannot be
   // determined.
   DWORD GetValueCount() const;
 
   // Determines the nth value's name.
   LONG GetValueNameAt(int index, std::wstring* name) const;
@@ skipping 179 matching lines @@
 
   wchar_t name_[MAX_PATH];
 
   DISALLOW_COPY_AND_ASSIGN(RegistryKeyIterator);
 };
 
 }  // namespace win
 }  // namespace base
 
 #endif  // BASE_WIN_REGISTRY_H_