Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2963763002: Change how unresolved super sends are handled. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change how unresolved super sends are handled. The mixin transformer is now responsible for adding no-such-method calls. Fixes https://github.com/dart-lang/sdk/issues/30000 R=paulberry@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/ba84f801f43ca12f1ed7c134ff44ff77286c2a43

Patch Set 1 #

Patch Set 2 : Add warning messages. #

Patch Set 3 : Rebased on 6cb702b723184ef8875871e4c15004d1ea0a8460. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+735 lines, -181 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 2 2 chunks +37 lines, -70 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 3 chunks +10 lines, -22 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 1 2 6 chunks +26 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/unresolved_super.dart.direct.expect View 1 chunk +4 lines, -4 lines 0 comments Download
A pkg/front_end/testcases/rasta/mixin_library.dart.strong.expect View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/rasta/super.dart.strong.expect View 1 2 1 chunk +263 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/rasta/super_mixin.dart.strong.expect View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/strong.status View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/super_rasta_copy.dart.direct.expect View 8 chunks +69 lines, -69 lines 0 comments Download
A pkg/front_end/testcases/super_rasta_copy.dart.strong.expect View 1 2 1 chunk +248 lines, -0 lines 0 comments Download
M tests/kernel/kernel.status View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ahe
3 years, 5 months ago (2017-06-28 12:53:56 UTC) #2
Paul Berry
lgtm I believe the crashes will be resolved by https://codereview.chromium.org/2956243003/
3 years, 5 months ago (2017-06-28 13:23:17 UTC) #3
ahe
Alex, this should fix super mixins. I plan to land this tomorrow.
3 years, 5 months ago (2017-06-28 17:23:19 UTC) #4
aam
On 2017/06/28 17:23:19, ahe wrote: > Alex, this should fix super mixins. I plan to ...
3 years, 5 months ago (2017-06-28 17:24:54 UTC) #6
Siggi Cherem (dart-lang)
lgtm
3 years, 5 months ago (2017-06-28 18:03:45 UTC) #8
ahe
3 years, 5 months ago (2017-06-29 10:21:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
ba84f801f43ca12f1ed7c134ff44ff77286c2a43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698