Fix discrepancies in form text selection between PDF and HTML forms.

pdf/pdfium/pdfium_engine.h

Index: pdf/pdfium/pdfium_engine.h
diff --git a/pdf/pdfium/pdfium_engine.h b/pdf/pdfium/pdfium_engine.h
index 5b46fc06689c0cf185135bc0ae42a0f048a12d27..7beebdd37b4d99b04d10669f45b9dbd3e2a6772b 100644
--- a/pdf/pdfium/pdfium_engine.h
+++ b/pdf/pdfium/pdfium_engine.h
@@ -453,6 +453,9 @@ class PDFiumEngine : public PDFEngine,
   // field.
   void SetInFormTextArea(bool in_form_text_area);
 
+  // Sets whether or not left mouse button is currently being held down.
+  void SetMouseHeldDown(bool mouse_held_down);

[Lei Zhang, 2017/06/30 21:39:36]

How about SetMouseLeftButtonDown(bool is_mouse_left_button_down) ?

[drgage, 2017/06/30 23:37:32]

Done.

+
   bool PageIndexInBounds(int index) const;
 
   void ScheduleTouchTimer(const pp::TouchInputEvent& event);
@@ -653,15 +656,22 @@ class PDFiumEngine : public PDFEngine,
   bool defer_page_unload_;
   std::vector<int> deferred_page_unloads_;
 
-  // Used for text selection, but does not include text within form text fields.
+  // Used for text selection, but does not include text within form text areas.
   // There could be more than one range if selection spans more than one page.
   std::vector<PDFiumRange> selection_;
   // True if we're in the middle of text selection.
   bool selecting_;
 
+  // Used for selection of text within form text areas (text fields and combo

[Lei Zhang, 2017/06/30 21:39:36]

Just: The currently selected text within form ...

[drgage, 2017/06/30 23:37:32]

Done.

+  // box text fields). Represents the currently selected text.
+  std::string selected_form_text_;
+
   // True if focus is in form text field or form combobox text field.
   bool in_form_text_area_;
 
+  // True if left mouse button is currently being held down.
+  bool mouse_held_down_;

[Lei Zhang, 2017/06/30 21:39:36]

Also rename to indicate it's the left mouse button.

[drgage, 2017/06/30 23:37:32]

Done.

+
   MouseDownState mouse_down_state_;

[Lei Zhang, 2017/06/30 21:39:36]

Let's move this up to be with |selecting_|, so the non-form text selection
variables are grouped together.

[drgage, 2017/06/30 23:37:32]

Done.

 
   // Used for searching.