Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2963743002: Revert "Make Zone API strong mode clean." (Closed)

Created:
3 years, 5 months ago by floitsch
Modified:
3 years, 5 months ago
Reviewers:
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Make Zone API strong mode clean." This reverts commit 0b35711d48b03cbcaaabde8e2b71704b2fa337e9. BUG= Committed: https://github.com/dart-lang/sdk/commit/978213d4272da4553a8931370c88789237a5ca2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -374 lines) Patch
M pkg/compiler/lib/src/common/tasks.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M sdk/lib/async/future.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/async/schedule_microtask.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/async/stream_impl.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M sdk/lib/async/timer.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M sdk/lib/async/zone.dart View 25 chunks +180 lines, -213 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 5 chunks +17 lines, -11 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +16 lines, -10 lines 0 comments Download
M tests/co19/co19-co19.status View 1 chunk +0 lines, -8 lines 0 comments Download
M tests/lib/async/async_await_zones_test.dart View 3 chunks +3 lines, -6 lines 0 comments Download
M tests/lib/async/future_timeout_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/lib/async/run_zoned6_test.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M tests/lib/async/run_zoned9_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/lib/async/stream_listen_zone_test.dart View 1 chunk +7 lines, -8 lines 0 comments Download
M tests/lib/async/zone_bind_callback_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/lib/async/zone_bind_callback_unary_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib/async/zone_debug_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/async/zone_fork_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/lib/async/zone_register_callback_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/lib/async/zone_register_callback_unary_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/zone_root_bind_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/zone_run_guarded_test.dart View 4 chunks +6 lines, -9 lines 0 comments Download
M tests/lib/async/zone_run_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/async/zone_run_unary_test.dart View 1 chunk +4 lines, -7 lines 0 comments Download
M tests/lib/mirrors/invocation_fuzz_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib_strong/async/async_await_zones_test.dart View 4 chunks +4 lines, -7 lines 0 comments Download
M tests/lib_strong/async/future_timeout_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/lib_strong/async/stream_listen_zone_test.dart View 1 chunk +7 lines, -8 lines 0 comments Download
M tests/lib_strong/async/zone_bind_callback_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/lib_strong/async/zone_bind_callback_unary_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib_strong/async/zone_debug_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib_strong/async/zone_fork_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/lib_strong/async/zone_register_callback_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/lib_strong/async/zone_register_callback_unary_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/async/zone_root_bind_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/async/zone_run_guarded_test.dart View 3 chunks +6 lines, -10 lines 0 comments Download
M tests/lib_strong/async/zone_run_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib_strong/async/zone_run_unary_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/lib_strong/mirrors/invocation_fuzz_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/dom/src/shared_html.dart View 1 chunk +11 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M utils/compiler/create_snapshot_entry.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
floitsch
3 years, 5 months ago (2017-06-28 11:31:39 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
978213d4272da4553a8931370c88789237a5ca2f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698