android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java - Issue 2963683002: Simplify CommandLine parameterizing J3 Instrumentation Tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java

Issue 2963683002: Simplify CommandLine parameterizing J3 Instrumentation Tests (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java ('k') | base/BUILD.gn » ('j') | build/android/pylib/instrumentation/instrumentation_test_instance.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java

index 373be1fc42ec5cf2a5c0fbedd81a97a2ed8629c7..17557534b38cf7ee736215fa374efb14c852fa3a 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java

@@ -27,7 +27,7 @@ import org.chromium.base.test.util.CallbackHelper;

import org.chromium.base.test.util.CommandLineFlags;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.RetryOnFailure;

-import org.chromium.base.test.util.parameter.ParameterizedTest;

+import org.chromium.base.test.util.parameter.SkipParameterization;

import org.chromium.content_public.common.ContentUrlConstants;

import java.util.concurrent.TimeUnit;

@@ -154,7 +154,7 @@ public class VisualStateCallbackTest extends AwTestBase {

@SmallTest

@CommandLineFlags

.Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)

- @ParameterizedTest.Set

+ @SkipParameterization

public void testAddVisualStateCallbackAfterRendererGone() throws Throwable {

final VisualStateCallbackImpl vsImpl = new VisualStateCallbackImpl();

mHelper.setOnRenderProcessGoneTask(new Runnable() {

@@ -179,7 +179,7 @@ public class VisualStateCallbackTest extends AwTestBase {

@RetryOnFailure

@CommandLineFlags

.Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)

- @ParameterizedTest.Set

+ @SkipParameterization

public void testVisualStateCallbackNotCalledAfterRendererGone() throws Throwable {

VisualStateCallbackImpl vsImpl = new VisualStateCallbackImpl();