Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: components/cronet/url_request_context_config_unittest.cc

Issue 2963643002: Fix Cronet tests. (Closed)
Patch Set: Oops Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/url_request_context_config_unittest.cc
diff --git a/components/cronet/url_request_context_config_unittest.cc b/components/cronet/url_request_context_config_unittest.cc
index 1ee203b1c4f1bc863e8211680ef309af1d5f2c1d..a88000d1ae52bcac034509645f23e9006a917790 100644
--- a/components/cronet/url_request_context_config_unittest.cc
+++ b/components/cronet/url_request_context_config_unittest.cc
@@ -5,7 +5,7 @@
#include "components/cronet/url_request_context_config.h"
#include "base/memory/ptr_util.h"
-#include "base/message_loop/message_loop.h"
+#include "base/test/scoped_task_environment.h"
#include "base/values.h"
#include "net/cert/cert_verifier.h"
#include "net/http/http_network_session.h"
@@ -20,6 +20,9 @@
namespace cronet {
TEST(URLRequestContextConfigTest, TestExperimentalOptionParsing) {
+ base::test::ScopedTaskEnvironment scoped_task_environment_(
+ base::test::ScopedTaskEnvironment::MainThreadType::IO);
+
URLRequestContextConfig config(
// Enable QUIC.
true,
@@ -64,7 +67,6 @@ TEST(URLRequestContextConfigTest, TestExperimentalOptionParsing) {
// Certificate verifier cache data.
"");
- base::MessageLoop message_loop;
net::URLRequestContextBuilder builder;
net::NetLog net_log;
config.ConfigureURLRequestContextBuilder(&builder, &net_log, nullptr);
@@ -111,6 +113,9 @@ TEST(URLRequestContextConfigTest, TestExperimentalOptionParsing) {
}
TEST(URLRequestContextConfigTest, SetQuicConnectionMigrationOptions) {
+ base::test::ScopedTaskEnvironment scoped_task_environment_(
+ base::test::ScopedTaskEnvironment::MainThreadType::IO);
+
URLRequestContextConfig config(
// Enable QUIC.
true,
@@ -145,7 +150,6 @@ TEST(URLRequestContextConfigTest, SetQuicConnectionMigrationOptions) {
// Certificate verifier cache data.
"");
- base::MessageLoop message_loop;
net::URLRequestContextBuilder builder;
net::NetLog net_log;
config.ConfigureURLRequestContextBuilder(&builder, &net_log, nullptr);

Powered by Google App Engine
This is Rietveld 408576698