chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc - Issue 2963613002: Remove the (broken and unneeded) 'force_update' option from ServiceWatcher::DiscoverNewDevices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc

Issue 2963613002: Remove the (broken and unneeded) 'force_update' option from ServiceWatcher::DiscoverNewDevices. (Closed)

Patch Set: Fixup yet another mac site revealed by CQ Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/cloud_print/privet_device_lister_impl.cc ('k') | chrome/browser/printing/cloud_print/privet_local_printer_lister.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc

diff --git a/chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc b/chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc

index 19e2e2da9cdb8a0908dcfb60a0432ab61c6a3332..4bb7bf46ba64665beaacf14ae29b9f76ce07b047 100644

--- a/chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc

+++ b/chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc

@@ -50,7 +50,7 @@ class MockServiceWatcher : public ServiceWatcher {

mock_delegate_->ServiceWatcherStarted(service_type_, this);

}

- MOCK_METHOD1(DiscoverNewServices, void(bool force_update));

+ MOCK_METHOD0(DiscoverNewServices, void());

MOCK_METHOD1(SetActivelyRefreshServices, void(

bool actively_refresh_services));

@@ -296,8 +296,8 @@ TEST_F(PrivetDeviceListerTest, DiscoverNewDevices) {

privet_lister.Start();

testing::Mock::VerifyAndClear(&mock_delegate_);

- EXPECT_CALL(*service_watcher, DiscoverNewServices(false));

- privet_lister.DiscoverNewDevices(false);

+ EXPECT_CALL(*service_watcher, DiscoverNewServices());

+ privet_lister.DiscoverNewDevices();

}