chrome/browser/media/router/discovery/mdns/dns_sd_registry_unittest.cc - Issue 2963613002: Remove the (broken and unneeded) 'force_update' option from ServiceWatcher::DiscoverNewDevices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/discovery/mdns/dns_sd_registry_unittest.cc

Issue 2963613002: Remove the (broken and unneeded) 'force_update' option from ServiceWatcher::DiscoverNewDevices. (Closed)

Patch Set: Fixup yet another mac site revealed by CQ Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/discovery/mdns/dns_sd_registry.cc ('k') | chrome/browser/printing/cloud_print/privet_device_lister.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/discovery/mdns/dns_sd_registry_unittest.cc

diff --git a/chrome/browser/media/router/discovery/mdns/dns_sd_registry_unittest.cc b/chrome/browser/media/router/discovery/mdns/dns_sd_registry_unittest.cc

index 38b87b3e502726c53db3a0489c0d526b342084d1..c988f51ece952792dd4afeabd7e4d81e9d55019b 100644

--- a/chrome/browser/media/router/discovery/mdns/dns_sd_registry_unittest.cc

+++ b/chrome/browser/media/router/discovery/mdns/dns_sd_registry_unittest.cc

@@ -15,7 +15,7 @@ class MockDnsSdDeviceLister : public DnsSdDeviceLister {

MockDnsSdDeviceLister() : DnsSdDeviceLister(NULL, NULL, "") {}

~MockDnsSdDeviceLister() override {}

- MOCK_METHOD1(Discover, void(bool force_update));

+ MOCK_METHOD0(Discover, void());

};

class TestDnsSdRegistry : public DnsSdRegistry {

@@ -116,8 +116,8 @@ TEST_F(DnsSdRegistryTest, ForceDiscovery) {

EXPECT_EQ(1, registry_->GetServiceListenerCount(service_type1));

EXPECT_EQ(1, registry_->GetServiceListenerCount(service_type2));

- EXPECT_CALL(*registry_->GetLister(service_type1), Discover(false));

- EXPECT_CALL(*registry_->GetLister(service_type2), Discover(false));

+ EXPECT_CALL(*registry_->GetLister(service_type1), Discover());

+ EXPECT_CALL(*registry_->GetLister(service_type2), Discover());

registry_->ForceDiscovery();

}