chrome/browser/local_discovery/service_discovery_client_unittest.cc - Issue 2963613002: Remove the (broken and unneeded) 'force_update' option from ServiceWatcher::DiscoverNewDevices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/service_discovery_client_unittest.cc

Issue 2963613002: Remove the (broken and unneeded) 'force_update' option from ServiceWatcher::DiscoverNewDevices. (Closed)

Patch Set: Fixup yet another mac site revealed by CQ Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/service_discovery_client_mdns.cc ('k') | chrome/browser/local_discovery/service_discovery_device_lister.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/service_discovery_client_unittest.cc

diff --git a/chrome/browser/local_discovery/service_discovery_client_unittest.cc b/chrome/browser/local_discovery/service_discovery_client_unittest.cc

index c252f4658c0336d53cca6233376de00c06d4aab2..63daa59cbf628bc815c6c0a856ee105bafd6b299 100644

--- a/chrome/browser/local_discovery/service_discovery_client_unittest.cc

+++ b/chrome/browser/local_discovery/service_discovery_client_unittest.cc

@@ -266,7 +266,7 @@ TEST_F(ServiceDiscoveryTest, DiscoverNewServices) {

EXPECT_CALL(socket_factory_, OnSendTo(_)).Times(2);

- watcher->DiscoverNewServices(false);

+ watcher->DiscoverNewServices();

EXPECT_CALL(socket_factory_, OnSendTo(_)).Times(2);

@@ -275,7 +275,6 @@ TEST_F(ServiceDiscoveryTest, DiscoverNewServices) {

TEST_F(ServiceDiscoveryTest, ReadCachedServices) {

socket_factory_.SimulateReceive(kSamplePacketPTR, sizeof(kSamplePacketPTR));

StrictMock<MockServiceWatcherClient> delegate;

std::unique_ptr<ServiceWatcher> watcher(