Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2963583002: Cache AnalysisOptionsImpl objects for context directories. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cache AnalysisOptionsImpl objects for context directories. This fixes the performance degradation which we had to introduce in the previous CL. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3d831505a4cf38b50b62421ccab72683ac92e9f0

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -89 lines) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 9 chunks +110 lines, -89 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-06-27 18:19:58 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2963583002/diff/1/pkg/analyzer_cli/lib/src/driver.dart File pkg/analyzer_cli/lib/src/driver.dart (right): https://codereview.chromium.org/2963583002/diff/1/pkg/analyzer_cli/lib/src/driver.dart#newcode470 pkg/analyzer_cli/lib/src/driver.dart:470: // TODO(devoncarew): This needs to respect analysis_options excludes. ...
3 years, 5 months ago (2017-06-27 19:11:02 UTC) #2
scheglov
3 years, 5 months ago (2017-06-27 19:18:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3d831505a4cf38b50b62421ccab72683ac92e9f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698