chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 2963573004: [Cleanup] Migrate the WatcherMetricsProvider to use the Task Scheduler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 2963573004: [Cleanup] Migrate the WatcherMetricsProvider to use the Task Scheduler. (Closed)

Patch Set: Bottleneck through a single sequence for access to the registry key Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index d14ba61230f17213dc16157e97c0bcef217a365e..481176b64649192182a75e52d0634bb24d9b443d 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -690,8 +690,7 @@ void ChromeMetricsServiceClient::RegisterMetricsServiceProviders() {

}

watcher_metrics_provider_ = new browser_watcher::WatcherMetricsProviderWin(

chrome::GetBrowserExitCodesRegistryPath(), user_data_dir, crash_dir,

- base::Bind(&GetExecutableVersionDetails),

- content::BrowserThread::GetBlockingPool());

+ base::Bind(&GetExecutableVersionDetails));

metrics_service_->RegisterMetricsProvider(

std::unique_ptr<metrics::MetricsProvider>(watcher_metrics_provider_));