chrome/android/java/res/layout/new_tab_page_incognito_md.xml - Issue 2963523002: Additional improvements of the new Incognito NTP

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_incognito_md.xml

Issue 2963523002: Additional improvements of the new Incognito NTP (Closed)

Patch Set: Rebase. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <org.chromium.chrome.browser.ntp.IncognitoNewTabPageViewMD	6 <org.chromium.chrome.browser.ntp.IncognitoNewTabPageViewMD

7 xmlns:android="http://schemas.android.com/apk/res/android"	7 xmlns:android="http://schemas.android.com/apk/res/android"

8 xmlns:chrome="http://schemas.android.com/apk/res-auto"	8 xmlns:chrome="http://schemas.android.com/apk/res-auto"

9 android:id="@+id/ntp_content"	9 android:id="@+id/ntp_content"

10 android:layout_width="match_parent"	10 android:layout_width="match_parent"

(...skipping 24 matching lines...) Expand all Loading...
35 android:id="@+id/new_tab_incognito_icon"	35 android:id="@+id/new_tab_incognito_icon"

36 android:layout_width="wrap_content"	36 android:layout_width="wrap_content"

37 android:layout_height="wrap_content"	37 android:layout_height="wrap_content"

38 android:contentDescription="@null"	38 android:contentDescription="@null"

39 android:src="@drawable/incognito_splash" />	39 android:src="@drawable/incognito_splash" />

40	40

41 <TextView	41 <TextView

42 android:id="@+id/new_tab_incognito_title"	42 android:id="@+id/new_tab_incognito_title"

43 android:layout_width="wrap_content"	43 android:layout_width="wrap_content"

44 android:layout_height="wrap_content"	44 android:layout_height="wrap_content"

45 android:fontFamily="sans-serif-light"

46 android:text="@string/new_tab_otr_title"	45 android:text="@string/new_tab_otr_title"

47 android:textColor="@color/incognito_header" />	46 android:textColor="@color/incognito_header" />

48	47

49 <TextView	48 <TextView

50 android:id="@+id/new_tab_incognito_subtitle"	49 android:id="@+id/new_tab_incognito_subtitle"

51 android:layout_width="match_parent"	50 android:layout_width="wrap_content"

52 android:layout_height="wrap_content"	51 android:layout_height="wrap_content"

53 android:fontFamily="sans-serif-light"

54 android:text="@string/new_tab_otr_subtitle"	52 android:text="@string/new_tab_otr_subtitle"

55 android:textColor="@color/incognito_header"	53 android:textColor="@color/incognito_header"

	54 android:singleLine="false"
	Michael van Ouwerkerk 2017/06/30 10:30:39 Here and below: the default value is false, so thi Here and below: the default value is false, so this line can be deleted. https://developer.android.com/reference/android/widget/TextView.html#attr_and... msramek 2017/06/30 13:27:23 Done. Show quoted text On 2017/06/30 10:30:39, Michael van Ouwerkerk wrote: > Here and below: the default value is false, so this line can be deleted. > > https://developer.android.com/reference/android/widget/TextView.html#attr_and... Done.
56 android:lineSpacingExtra="6sp" />	55 android:lineSpacingExtra="6sp" />

57	56

58 <TextView	57 <LinearLayout

59 android:id="@+id/new_tab_incognito_features"	58 android:id="@+id/new_tab_incognito_bulletpoints_container"

60 android:layout_width="match_parent"	59 android:layout_width="wrap_content"

61 android:layout_height="wrap_content"	60 android:layout_height="wrap_content"

62 android:singleLine="false"	61 android:orientation="horizontal"

63 android:textColor="@color/incognito_text"	62 android:gravity="start">

64 android:lineSpacingExtra="6sp" />

65	63

66 <TextView	64 <TextView

67 android:id="@+id/new_tab_incognito_warning"	65 android:id="@+id/new_tab_incognito_features"

68 android:layout_width="match_parent"	66 android:layout_width="wrap_content"

69 android:layout_height="wrap_content"	67 android:layout_height="wrap_content"

70 android:singleLine="false"	68 android:singleLine="false"

71 android:textColor="@color/incognito_text"	69 android:textColor="@color/incognito_text"

72 android:lineSpacingExtra="6sp" />	70 android:lineSpacingExtra="6sp" />

	71

	72 <TextView

	73 android:id="@+id/new_tab_incognito_warning"

	74 android:layout_width="wrap_content"

	75 android:layout_height="wrap_content"

	76 android:singleLine="false"

	77 android:textColor="@color/incognito_text"

	78 android:lineSpacingExtra="6sp" />

	79

	80 </LinearLayout>

73	81

74 <TextView	82 <TextView

75 android:id="@+id/learn_more"	83 android:id="@+id/learn_more"

76 android:layout_width="wrap_content"	84 android:layout_width="wrap_content"

77 android:layout_height="wrap_content"	85 android:layout_height="wrap_content"

78 android:background="?attr/listChoiceBackgroundIndicator"	86 android:background="?attr/listChoiceBackgroundIndicator"

79 android:clickable="true"	87 android:clickable="true"

80 android:focusable="true"	88 android:focusable="true"

81 android:text="@string/learn_more"	89 android:text="@string/learn_more"

82 android:textColor="@color/google_blue_300"	90 android:textColor="@color/google_blue_300"

83 android:lineSpacingExtra="6sp"	91 android:lineSpacingExtra="6sp"

84 style="@style/RobotoMediumStyle" />	92 style="@style/RobotoMediumStyle" />

85	93

86 </LinearLayout>	94 </LinearLayout>

87	95

88 </org.chromium.chrome.browser.ntp.NewTabPageScrollView>	96 </org.chromium.chrome.browser.ntp.NewTabPageScrollView>

89	97

90 </org.chromium.chrome.browser.ntp.IncognitoNewTabPageViewMD>	98 </org.chromium.chrome.browser.ntp.IncognitoNewTabPageViewMD>

OLD	NEW