tokenserver/appengine/impl/certconfig/rpc_fetch_crl.go - Issue 2963503003: [errors] Greatly simplify common/errors package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tokenserver/appengine/impl/certconfig/rpc_fetch_crl.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)

Patch Set: fix nits Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tokenserver/appengine/impl/certconfig/rpc_fetch_crl.go

diff --git a/tokenserver/appengine/impl/certconfig/rpc_fetch_crl.go b/tokenserver/appengine/impl/certconfig/rpc_fetch_crl.go

index 6d6e426bee9d59b97f258a716ca662ac8740fb39..5b78a3216cc4eed16ec88239c5fe903c125e9cf8 100644

--- a/tokenserver/appengine/impl/certconfig/rpc_fetch_crl.go

+++ b/tokenserver/appengine/impl/certconfig/rpc_fetch_crl.go

@@ -142,8 +142,8 @@ func fetchCRL(c context.Context, cfg *admin.CertificateAuthorityConfig, knownETa

// Transient error?

if resp.StatusCode >= http.StatusInternalServerError {

logging.Warningf(c, "GET %s - HTTP %d; %q", cfg.CrlUrl, resp.StatusCode, string(blob))

- return nil, "", errors.Reason("server replied with HTTP %(code)d").

- D("code", resp.StatusCode).Tag(transient.Tag).Err()

+ return nil, "", errors.Reason("server replied with HTTP %d", resp.StatusCode).

+ Tag(transient.Tag).Err()

}

// Something we don't support or expect?