luci_config/server/cfgclient/backend/client/client.go - Issue 2963503003: [errors] Greatly simplify common/errors package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: luci_config/server/cfgclient/backend/client/client.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)

Patch Set: fix nits Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: luci_config/server/cfgclient/backend/client/client.go

diff --git a/luci_config/server/cfgclient/backend/client/client.go b/luci_config/server/cfgclient/backend/client/client.go

index 57969a7ec52fc9e97a20b51cc52051188e3ceb6f..c28cc3559aab4bf69c6d2e259ab19a19db7b2ad7 100644

--- a/luci_config/server/cfgclient/backend/client/client.go

+++ b/luci_config/server/cfgclient/backend/client/client.go

@@ -75,7 +75,7 @@ func (be *Backend) GetAll(c context.Context, t backend.GetAllTarget, path string

case backend.GetAllRef:

fn = svc.GetRefConfigs

default:

- return nil, errors.Reason("unknown GetAllType: %(type)q").D("type", t).Err()

+ return nil, errors.Reason("unknown GetAllType: %q", t).Err()

}

cfgs, err := fn(c, path, !p.Content)