Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: luci_config/appengine/backend/datastore/ds.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/server/service/service.go ('k') | luci_config/appengine/backend/memcache/cache.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: luci_config/appengine/backend/datastore/ds.go
diff --git a/luci_config/appengine/backend/datastore/ds.go b/luci_config/appengine/backend/datastore/ds.go
index ccb7f64b3c39a7204bd79ddee80b2d05883bc1f0..386ed8538428c1338214e39168d2c5ee5baba0c4 100644
--- a/luci_config/appengine/backend/datastore/ds.go
+++ b/luci_config/appengine/backend/datastore/ds.go
@@ -143,7 +143,7 @@ func (dc *Config) cacheGet(c context.Context, key caching.Key, l caching.Loader)
// operation that is being performed.
encKey, err := caching.Encode(&key)
if err != nil {
- return nil, errors.Annotate(err).Reason("failed to encode cache key").Err()
+ return nil, errors.Annotate(err, "failed to encode cache key").Err()
}
// Construct a cache handler.
@@ -154,13 +154,13 @@ func (dc *Config) cacheGet(c context.Context, key caching.Key, l caching.Loader)
// Decode our response.
if v.Schema != dsCacheSchema {
- return nil, errors.Reason("response schema (%(resp)q) doesn't match current (%(cur)q)").
- D("resp", v.Schema).D("cur", dsCacheSchema).Err()
+ return nil, errors.Reason("response schema (%q) doesn't match current (%q)",
+ v.Schema, dsCacheSchema).Err()
}
cacheValue, err := caching.DecodeValue(v.Data)
if err != nil {
- return nil, errors.Annotate(err).Reason("failed to decode cached value").Err()
+ return nil, errors.Annotate(err, "failed to decode cached value").Err()
}
// Prune any responses that are not permitted for the supplied Authority.
@@ -250,7 +250,7 @@ func (dch *dsCacheHandler) Refresh(c context.Context, key []byte, v datastorecac
// Decode the key into our caching key.
var ck caching.Key
if err := caching.Decode(key, &ck); err != nil {
- return v, errors.Annotate(err).Reason("failed to decode cache key").Err()
+ return v, errors.Annotate(err, "failed to decode cache key").Err()
}
var cv *caching.Value
@@ -258,7 +258,7 @@ func (dch *dsCacheHandler) Refresh(c context.Context, key []byte, v datastorecac
// We have a currently-cached value, so decode it into "cv".
var err error
if cv, err = caching.DecodeValue(v.Data); err != nil {
- return v, errors.Annotate(err).Reason("failed to decode cache value").Err()
+ return v, errors.Annotate(err, "failed to decode cache value").Err()
}
}
@@ -272,7 +272,7 @@ func (dch *dsCacheHandler) Refresh(c context.Context, key []byte, v datastorecac
// Perform a cache load on this value.
cv, err := dch.loader(c, ck, cv)
if err != nil {
- return v, errors.Annotate(err).Reason("failed to load cache value").Err()
+ return v, errors.Annotate(err, "failed to load cache value").Err()
}
keyDesc := ck.String()
@@ -281,7 +281,7 @@ func (dch *dsCacheHandler) Refresh(c context.Context, key []byte, v datastorecac
// Encode the resulting cache value.
if v.Data, err = cv.Encode(); err != nil {
- return v, errors.Annotate(err).Reason("failed to encode cache value").Err()
+ return v, errors.Annotate(err, "failed to encode cache value").Err()
}
v.Schema = dsCacheSchema
v.Description = keyDesc + ": " + valueDesc
« no previous file with comments | « logdog/server/service/service.go ('k') | luci_config/appengine/backend/memcache/cache.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698