logdog/server/archivist/archivist.go - Issue 2963503003: [errors] Greatly simplify common/errors package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: logdog/server/archivist/archivist.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)

Patch Set: fix nits Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: logdog/server/archivist/archivist.go

diff --git a/logdog/server/archivist/archivist.go b/logdog/server/archivist/archivist.go

index b1b3d538c4f3b7ac92c9a3f897c132a69b683ed7..829903ba28ff163e07f4f67286790851d4546a99 100644

--- a/logdog/server/archivist/archivist.go

+++ b/logdog/server/archivist/archivist.go

@@ -538,7 +538,7 @@ func (sa *stagedArchival) checkComplete(c context.Context) error {

err := sa.Storage.Get(sreq, func(e *storage.Entry) bool {

idx, err := e.GetStreamIndex()

if err != nil {

- ierr = errors.Annotate(err).Reason("could not get stream index").Err()

+ ierr = errors.Annotate(err, "could not get stream index").Err()

return false

}

« no previous file with comments | « logdog/common/types/streamaddr.go ('k') | logdog/server/service/config/poller.go » ('j') | no next file with comments »