Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: logdog/client/cli/subcommandCat.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/client/cli/main.go ('k') | logdog/client/cli/subcommandLatest.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/client/cli/subcommandCat.go
diff --git a/logdog/client/cli/subcommandCat.go b/logdog/client/cli/subcommandCat.go
index a770eaef718bcd0e6e5038f0d67968cb625583b2..4f4aad2880562cadf6d17cc7fae571a82501ad52 100644
--- a/logdog/client/cli/subcommandCat.go
+++ b/logdog/client/cli/subcommandCat.go
@@ -121,8 +121,7 @@ func (cmd *catCommandRun) Run(scApp subcommands.Application, args []string, _ su
}
if addr.Host, err = a.resolveHost(""); err != nil {
- err = errors.Annotate(err).Reason("failed to resolve host: %(host)q").
- D("host", addr.Host).Err()
+ err = errors.Annotate(err, "failed to resolve host: %q", addr.Host).Err()
errors.Log(a, err)
return 1
}
@@ -143,8 +142,7 @@ func (cmd *catCommandRun) Run(scApp subcommands.Application, args []string, _ su
var err error
if coords[addr.Host], err = a.coordinatorClient(addr.Host); err != nil {
- err = errors.Annotate(err).Reason("failed to create Coordinator client for %(host)q").
- D("host", addr.Host).Err()
+ err = errors.Annotate(err, "failed to create Coordinator client for %q", addr.Host).Err()
errors.Log(a, err)
return 1
« no previous file with comments | « logdog/client/cli/main.go ('k') | logdog/client/cli/subcommandLatest.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698