Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: logdog/client/butler/streamserver/tcp.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: logdog/client/butler/streamserver/tcp.go
diff --git a/logdog/client/butler/streamserver/tcp.go b/logdog/client/butler/streamserver/tcp.go
index 057d7e444ccd04e9e952142cb434b7e6a0a5c765..f90d5b0767f5d6ccf45a6f9a2e175470cd0d32d1 100644
--- a/logdog/client/butler/streamserver/tcp.go
+++ b/logdog/client/butler/streamserver/tcp.go
@@ -57,10 +57,7 @@ func NewTCP6Server(ctx context.Context, spec string) (StreamServer, error) {
func newTCPServerImpl(ctx context.Context, netType, spec string, loopback net.IP) (StreamServer, error) {
tcpAddr, err := net.ResolveTCPAddr(netType, spec)
if err != nil {
- return nil, errors.Annotate(err).Reason("could not resolve %(net)q address %(addr)q").
- D("net", netType).
- D("addr", spec).
- Err()
+ return nil, errors.Annotate(err, "could not resolve %q address %q", netType, spec).Err()
}
if tcpAddr.IP == nil {
@@ -73,10 +70,7 @@ func newTCPServerImpl(ctx context.Context, netType, spec string, loopback net.IP
gen: func() (net.Listener, string, error) {
l, err := net.ListenTCP(netType, tcpAddr)
if err != nil {
- return nil, "", errors.Annotate(err).Reason("failed to listen to %(net)q address %(addr)q").
- D("net", netType).
- D("addr", tcpAddr).
- Err()
+ return nil, "", errors.Annotate(err, "failed to listen to %q address %q", netType, tcpAddr).Err()
}
addr := fmt.Sprintf("%s:%s", netType, l.Addr().String())
« no previous file with comments | « logdog/client/butler/streamserver/namedPipe_windows.go ('k') | logdog/client/butlerlib/bootstrap/bootstrap.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698