Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: logdog/client/butler/streamserver/namedPipe_windows.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/client/butler/streamserver/namedPipe_posix.go ('k') | logdog/client/butler/streamserver/tcp.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/client/butler/streamserver/namedPipe_windows.go
diff --git a/logdog/client/butler/streamserver/namedPipe_windows.go b/logdog/client/butler/streamserver/namedPipe_windows.go
index fb3d0c025e3a58ce61336c01884ba4b58f12d69e..1a90cf94adfc6478926ca5f0da49e00fa4692532 100644
--- a/logdog/client/butler/streamserver/namedPipe_windows.go
+++ b/logdog/client/butler/streamserver/namedPipe_windows.go
@@ -25,10 +25,8 @@ func NewNamedPipeServer(ctx context.Context, name string) (StreamServer, error)
case l == 0:
return nil, errors.New("cannot have empty name")
case l > maxWindowsNamedPipeLength:
- return nil, errors.Reason("name exceeds maximum length %(max)d").
- D("name", name).
- D("max", maxWindowsNamedPipeLength).
- Err()
+ return nil, errors.Reason("name exceeds maximum length %d", maxWindowsNamedPipeLength).
+ InternalReason("name(%s)", name).Err()
}
ctx = log.SetField(ctx, "name", name)
@@ -44,7 +42,7 @@ func NewNamedPipeServer(ctx context.Context, name string) (StreamServer, error)
l, err := winio.ListenPipe(pipePath, nil)
if err != nil {
- return nil, "", errors.Annotate(err).Reason("failed to listen on named pipe").Err()
+ return nil, "", errors.Annotate(err, "failed to listen on named pipe").Err()
}
return l, address, nil
},
« no previous file with comments | « logdog/client/butler/streamserver/namedPipe_posix.go ('k') | logdog/client/butler/streamserver/tcp.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698