Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: logdog/client/butler/streamserver/namedPipe_posix.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: logdog/client/butler/streamserver/namedPipe_posix.go
diff --git a/logdog/client/butler/streamserver/namedPipe_posix.go b/logdog/client/butler/streamserver/namedPipe_posix.go
index eb378043663cbcc97eb2a39f021b5b975854f08c..df118dc6e3c05fa9a90d9f5372eb9b56d4c5102b 100644
--- a/logdog/client/butler/streamserver/namedPipe_posix.go
+++ b/logdog/client/butler/streamserver/namedPipe_posix.go
@@ -32,17 +32,13 @@ func NewUNIXDomainSocketServer(ctx context.Context, path string) (StreamServer,
case l == 0:
return nil, errors.New("cannot have empty path")
case l > maxPOSIXNamedSocketLength:
- return nil, errors.Reason("path exceeds maximum length %(max)d").
- D("path", path).
- D("max", maxPOSIXNamedSocketLength).
- Err()
+ return nil, errors.Reason("path exceeds maximum length %d", maxPOSIXNamedSocketLength).
+ InternalReason("path(%s)", path).Err()
}
abs, err := filepath.Abs(path)
if err != nil {
- return nil, errors.Annotate(err).Reason("could not get absolute path of [%(path)s]").
- D("path", path).
- Err()
+ return nil, errors.Annotate(err, "could not get absolute path of [%s]", path).Err()
}
path = abs
« no previous file with comments | « logdog/client/butler/output/logdog/output.go ('k') | logdog/client/butler/streamserver/namedPipe_windows.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698