Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2040)

Unified Diff: dm/appengine/distributor/swarming/v1/isolate.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/appengine/distributor/swarming/v1/distributor.go ('k') | dm/appengine/mutate/add_deps.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/appengine/distributor/swarming/v1/isolate.go
diff --git a/dm/appengine/distributor/swarming/v1/isolate.go b/dm/appengine/distributor/swarming/v1/isolate.go
index a829dc7218bbac456e64defdc1dd4cf0f76520b9..e503a2540f9c93b99673392941677a7cc45c30b4 100644
--- a/dm/appengine/distributor/swarming/v1/isolate.go
+++ b/dm/appengine/distributor/swarming/v1/isolate.go
@@ -94,10 +94,7 @@ func pushIsolate(c context.Context, isolateURL string, chunks []isoChunk) error
anonC, authC, isolateURL, isolatedclient.DefaultNamespace, nil, nil)
states, err := isoClient.Contains(c, dgsts)
if err != nil {
- err = errors.Annotate(err).
- D("count", len(dgsts)).
- Reason("checking containment for %(count)d digests").
- Err()
+ err = errors.Annotate(err, "checking containment for %d digests", len(dgsts)).Err()
return err
}
return parallel.FanOutIn(func(ch chan<- func() error) {
@@ -127,7 +124,7 @@ func prepIsolate(c context.Context, isolateURL string, desc *dm.Quest_Desc, prev
{data: isoData, file: isoFile, isIso: true},
})
if err != nil {
- err = errors.Annotate(err).Reason("pushing new Isolated").Err()
+ err = errors.Annotate(err, "pushing new Isolated").Err()
return nil, err
}
« no previous file with comments | « dm/appengine/distributor/swarming/v1/distributor.go ('k') | dm/appengine/mutate/add_deps.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698