dm/appengine/distributor/notify_execution.go - Issue 2963503003: [errors] Greatly simplify common/errors package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/appengine/distributor/notify_execution.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)

Patch Set: fix nits Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/appengine/distributor/notify_execution.go

diff --git a/dm/appengine/distributor/notify_execution.go b/dm/appengine/distributor/notify_execution.go

index bc46f2d2d49d38f0891dc18f1cf60e8cfcad1dd3..1538195c3b4a99763ad895624c9265bcb81b29b1 100644

--- a/dm/appengine/distributor/notify_execution.go

+++ b/dm/appengine/distributor/notify_execution.go

@@ -40,7 +40,7 @@ func (f *NotifyExecution) RollForward(c context.Context) (muts []tumble.Mutation

q := &model.Quest{ID: f.Notification.ID.Quest}

if err := ds.Get(ds.WithoutTransaction(c), q); err != nil {

- return nil, errors.Annotate(err).Reason("getting Quest").Err()

+ return nil, errors.Annotate(err, "getting Quest").Err()

}

rslt, err := dist.HandleNotification(&q.Desc, f.Notification)

if err != nil {

« no previous file with comments | « dm/appengine/deps/util.go ('k') | dm/appengine/distributor/swarming/v1/distributor.go » ('j') | no next file with comments »