Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: dm/appengine/deps/service.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/appengine/deps/ensure_graph_data.go ('k') | dm/appengine/deps/util.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/appengine/deps/service.go
diff --git a/dm/appengine/deps/service.go b/dm/appengine/deps/service.go
index 2c67361e82295288d5cb9cd69f45bc6fe4ed0cc3..eb125bf2dbdf998c9c272394f65b65a0fe53a4cc 100644
--- a/dm/appengine/deps/service.go
+++ b/dm/appengine/deps/service.go
@@ -5,7 +5,6 @@
package deps
import (
- "bytes"
"os"
"github.com/golang/protobuf/proto"
@@ -35,7 +34,7 @@ func depsServerPrelude(c context.Context, methodName string, req proto.Message)
Normalize() error
}); ok {
if err := norm.Normalize(); err != nil {
- return nil, grpcAnnotate(err, codes.InvalidArgument).Reason("invalid request").Err()
+ return nil, grpcAnnotate(err, codes.InvalidArgument, "invalid request").Err()
}
}
return c, nil
@@ -65,9 +64,7 @@ func depsServerPostlude(c context.Context, methodName string, rsp proto.Message,
printStack = !omitStack
}
if printStack {
- buf := &bytes.Buffer{}
- errors.RenderStack(err).DumpTo(buf)
- logging.Errorf(c, "%s", buf.String())
+ errors.Log(c, err)
} else {
logging.Infof(c, "returning gRPC code: %s", code)
}
« no previous file with comments | « dm/appengine/deps/ensure_graph_data.go ('k') | dm/appengine/deps/util.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698