Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Unified Diff: deploytool/cmd/luci_deploy/version.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « deploytool/cmd/luci_deploy/util.go ('k') | deploytool/cmd/luci_deploy/work.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: deploytool/cmd/luci_deploy/version.go
diff --git a/deploytool/cmd/luci_deploy/version.go b/deploytool/cmd/luci_deploy/version.go
index 88ea383de6890a3f8d8050fbbf89883425ae6948..8aed5dc130ecdff66b7ed2d912a26f51368345a0 100644
--- a/deploytool/cmd/luci_deploy/version.go
+++ b/deploytool/cmd/luci_deploy/version.go
@@ -51,14 +51,14 @@ func (b cloudProjectVersionBuilder) build(cp *layoutDeploymentCloudProject, src
if src.sg.Tainted {
username, err := b.getCurrentUser()
if err != nil {
- return nil, errors.Annotate(err).Reason("could not get tained user").Err()
+ return nil, errors.Annotate(err, "could not get tained user").Err()
}
cpv.taintedUser = cloudVersionStringNormalize(username)
}
return &cpv, nil
default:
- return nil, errors.Reason("unknown version scheme %(scheme)v").D("scheme", vs).Err()
+ return nil, errors.Reason("unknown version scheme %v", vs).Err()
}
}
@@ -70,7 +70,7 @@ func (b *cloudProjectVersionBuilder) getCurrentUser() (string, error) {
// Default "currentUser" function uses "os.User".
user, err := user.Current()
if err != nil {
- return "", errors.Annotate(err).Reason("could not get tained user").Err()
+ return "", errors.Annotate(err, "could not get tained user").Err()
}
return user.Username, nil
}
@@ -95,12 +95,11 @@ func parseCloudProjectVersion(vs deploy.Deployment_CloudProject_VersionScheme, v
return &cpv, nil
default:
- return nil, errors.Reason("bad version %(version)q for scheme %(scheme)T").
- D("version", v).D("scheme", vs).Err()
+ return nil, errors.Reason("bad version %q for scheme %T", v, vs).Err()
}
default:
- return nil, errors.Reason("unknown version scheme %(scheme)T").D("scheme", vs).Err()
+ return nil, errors.Reason("unknown version scheme %T", vs).Err()
}
}
« no previous file with comments | « deploytool/cmd/luci_deploy/util.go ('k') | deploytool/cmd/luci_deploy/work.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698