Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: deploytool/cmd/luci_deploy/manage.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « deploytool/cmd/luci_deploy/layout.go ('k') | deploytool/cmd/luci_deploy/param.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: deploytool/cmd/luci_deploy/manage.go
diff --git a/deploytool/cmd/luci_deploy/manage.go b/deploytool/cmd/luci_deploy/manage.go
index f6fba78f89cee4d7ca8928b95ff649c614dc5879..b6f01de415f740e28d4b268c02b6aa445f43b8ee 100644
--- a/deploytool/cmd/luci_deploy/manage.go
+++ b/deploytool/cmd/luci_deploy/manage.go
@@ -86,7 +86,7 @@ func getManager(c context.Context, a *application, name string) (*manageApp, err
return mApp.dp.initialize(w, &a.layout)
})
if err != nil {
- return nil, errors.Annotate(err).Reason("failed to initialize deployment plan").Err()
+ return nil, errors.Annotate(err, "failed to initialize deployment plan").Err()
}
switch comp.GetComponent().(type) {
@@ -136,7 +136,7 @@ func getManager(c context.Context, a *application, name string) (*manageApp, err
return mApp.dp.initialize(w, &a.layout)
})
if err != nil {
- return nil, errors.Annotate(err).Reason("failed to initialize deployment plan").Err()
+ return nil, errors.Annotate(err, "failed to initialize deployment plan").Err()
}
if cp := dep.cloudProject; cp != nil {
@@ -182,12 +182,12 @@ func (cmd *manageGKEPodKubectlCommandRun) Run(app subcommands.Application, args
err = a.runWork(c, func(w *work) error {
kubeCtx, err := getContainerEngineKubernetesContext(w, bp.cluster)
if err != nil {
- return errors.Annotate(err).Err()
+ return errors.Annotate(err, "").Err()
}
kubectl, err := w.tools.kubectl(kubeCtx)
if err != nil {
- return errors.Annotate(err).Err()
+ return errors.Annotate(err, "").Err()
}
rv, err = kubectl.exec(args...).forwardOutput().run(w)
@@ -252,11 +252,11 @@ func (cmd *manageGKEPodCreateClusterCommandRun) Run(app subcommands.Application,
cloudProjectName := bp.pod.comp.dep.cloudProject.Name
gcloud, err := w.tools.gcloud(cloudProjectName)
if err != nil {
- return errors.Annotate(err).Err()
+ return errors.Annotate(err, "").Err()
}
if rv, err = gcloud.exec(gcloudArgs[0], gcloudArgs[1:]...).run(w); err != nil {
- return errors.Annotate(err).Reason("failed to run 'gcloud' command").Err()
+ return errors.Annotate(err, "failed to run 'gcloud' command").Err()
}
return nil
})
@@ -275,9 +275,7 @@ func getPodBindingForCluster(comp *layoutDeploymentComponent, cluster string) (*
case cluster != "":
cluster := comp.dep.cloudProject.gkeClusters[cluster]
if cluster == nil {
- return nil, errors.Reason("invalid GKE cluster name: %(name)q").
- D("name", cluster).
- Err()
+ return nil, errors.Reason("invalid GKE cluster name: %q", cluster).Err()
}
for _, gkeBP := range comp.gkePods {
if gkeBP.cluster == cluster {
@@ -299,8 +297,7 @@ func getPodBindingForCluster(comp *layoutDeploymentComponent, cluster string) (*
}
return nil, errors.Reason("the Kubernetes pod is bound to multiple clusters. Specify one with -cluster").
- D("clusters", clusters).
- Err()
+ InternalReason("clusters(%v)", clusters).Err()
}
if bp == nil {
return nil, errors.New("Could not identify cluster for pod.")
« no previous file with comments | « deploytool/cmd/luci_deploy/layout.go ('k') | deploytool/cmd/luci_deploy/param.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698