Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: cipd/client/cipd/ensure/package_def.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cipd/client/cipd/ensure/file.go ('k') | cipd/client/cipd/ensure/template.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cipd/client/cipd/ensure/package_def.go
diff --git a/cipd/client/cipd/ensure/package_def.go b/cipd/client/cipd/ensure/package_def.go
index 1efe662c820ed186b44f3b4c33c69f1a4160a7d3..798e01d0b0689b319443488c4ae61c6aa6ca90dd 100644
--- a/cipd/client/cipd/ensure/package_def.go
+++ b/cipd/client/cipd/ensure/package_def.go
@@ -47,19 +47,13 @@ func (p *PackageDef) Resolve(rslv VersionResolver, templateArgs map[string]strin
return
}
if err != nil {
- err = errors.Annotate(err).
- Reason("failed to resolve package template (line %(line)d)").
- D("line", p.LineNo).
- Err()
+ err = errors.Annotate(err, "failed to resolve package template (line %d)", p.LineNo).Err()
return
}
pin, err = rslv(pin.PackageName, p.UnresolvedVersion)
if err != nil {
- err = errors.Annotate(err).
- Reason("failed to resolve package version (line %(line)d)").
- D("line", p.LineNo).
- Err()
+ err = errors.Annotate(err, "failed to resolve package version (line %d)", p.LineNo).Err()
return
}
« no previous file with comments | « cipd/client/cipd/ensure/file.go ('k') | cipd/client/cipd/ensure/template.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698