deploytool/cmd/luci_deploy/title.go - Issue 2963503003: [errors] Greatly simplify common/errors package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: deploytool/cmd/luci_deploy/title.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)

Patch Set: all tests passing Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: deploytool/cmd/luci_deploy/title.go

diff --git a/deploytool/cmd/luci_deploy/title.go b/deploytool/cmd/luci_deploy/title.go

index f2e77dbd5ce90396a119cae52bade88d0b01dcac..082a1b39129a55620920bbc3371807e0ecdef12c 100644

--- a/deploytool/cmd/luci_deploy/title.go

+++ b/deploytool/cmd/luci_deploy/title.go

@@ -21,8 +21,7 @@ func (t title) validate() error {

idx := 0

for _, r := range t {

if !(unicode.IsLetter(r) || unicode.IsNumber(r) || r == '-') {

- return errors.Reason("character at %(pos)d (%(char)c) is not permitted in a title").

- D("pos", idx).D("char", r).Err()

+ return errors.Reason("character at %d (%c) is not permitted in a title", idx, r).Err()

}

idx++

}