Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: chrome/browser/installable/installable_manager.h

Issue 2963473003: Don't block InstallableManager::GetData calls when waiting for a service worker. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/installable/installable_manager.h
diff --git a/chrome/browser/installable/installable_manager.h b/chrome/browser/installable/installable_manager.h
index 1a53d37bc7cb1580e30d07f5ac2a1acda24a3283..0a1c51c18ea83d8dc4ea27ac7f61101f288f94ac 100644
--- a/chrome/browser/installable/installable_manager.h
+++ b/chrome/browser/installable/installable_manager.h
@@ -194,7 +194,6 @@ class InstallableManager
InstallableStatusCode valid_manifest_error() const;
void set_valid_manifest_error(InstallableStatusCode error_code);
InstallableStatusCode worker_error() const;
- bool worker_waiting() const;
InstallableStatusCode icon_error(const IconParams& icon_params);
GURL& icon_url(const IconParams& icon_params);
const SkBitmap* icon(const IconParams& icon);
@@ -249,6 +248,9 @@ class InstallableManager
// The list of <params, callback> pairs that have come from a call to GetData.
std::vector<Task> tasks_;
+ // Tasks which are waiting indefinitely for a service worker to be detected.
+ std::vector<Task> paused_tasks_;
+
// Installable properties cached on this object.
std::unique_ptr<ManifestProperty> manifest_;
std::unique_ptr<ValidManifestProperty> valid_manifest_;

Powered by Google App Engine
This is Rietveld 408576698