Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 296343002: Fix potential crash related to loading an invalid image URL (Closed)

Created:
6 years, 7 months ago by cbiesinger
Modified:
6 years, 6 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Yoav Weiss
Visibility:
Public.

Description

Fix potential crash related to loading an invalid image URL This does not fix the clusterfuzz testcase in the bug, but I found it while investigating that bug. See also the comment at the top of doUpdateElement. I was unable to write a crashing testcase for this... R=eseidel,esprehn BUG=376748 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M Source/core/loader/ImageLoader.cpp View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cbiesinger
6 years, 7 months ago (2014-05-24 01:08:58 UTC) #1
eseidel
This is a nate review.
6 years, 6 months ago (2014-05-28 23:26:29 UTC) #2
Nate Chapin
On 2014/05/28 23:26:29, eseidel wrote: > This is a nate review. LGTM, but please cc: ...
6 years, 6 months ago (2014-05-28 23:30:32 UTC) #3
Mark Mentovai
lgtm Christian asked me to hit the CQ for him.
6 years, 6 months ago (2014-05-29 20:19:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/296343002/1
6 years, 6 months ago (2014-05-29 20:21:53 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 00:50:05 UTC) #6
Message was sent while issue was closed.
Change committed as 175087

Powered by Google App Engine
This is Rietveld 408576698