Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 296333002: Revert 174726 "[webcrypto] Remove RSA-ES support (3 of 3)" (Closed)

Created:
6 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
eroman
CC:
blink-reviews
Visibility:
Public.

Description

Revert 174726 "[webcrypto] Remove RSA-ES support (3 of 3)" Broke build on Android. See bug 372920 for details. BUG=372920, 245025 > [webcrypto] Remove RSA-ES support (3 of 3) > > * RSA-ES keys that were previously serialized via structured clone will not be readable after this change. Since WebCrypto is behind an experimental flag this breakage is acceptable. > > * Removes some related code. Parameters for generating and importing RSA keys had the notion of being hashed or not. With RSA-ES gone, all of the RSA keys enumerated by the spec are "hashed" (rsa-ssa, rsa-oaep, rsa-pss) so this distinction isn't necessary. > > BUG=372920, 245025 > R=jochen@chromium.org, jsbell@chromium.org, jww@chromium.org > > Review URL: https://codereview.chromium.org/284973002 TBR=eroman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -54 lines) Patch
M trunk/Source/bindings/v8/SerializedScriptValue.cpp View 11 chunks +35 lines, -15 lines 0 comments Download
M trunk/Source/modules/crypto/KeyAlgorithm.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/modules/crypto/KeyAlgorithm.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M trunk/Source/modules/crypto/KeyAlgorithm.idl View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/modules/crypto/NormalizeAlgorithm.cpp View 12 chunks +62 lines, -23 lines 0 comments Download
M trunk/Source/modules/crypto/RsaKeyAlgorithm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/Source/modules/crypto/RsaKeyAlgorithm.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/platform/exported/WebCryptoAlgorithm.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M trunk/Source/platform/exported/WebCryptoKeyAlgorithm.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M trunk/public/platform/WebCryptoAlgorithm.h View 4 chunks +4 lines, -0 lines 0 comments Download
M trunk/public/platform/WebCryptoAlgorithmParams.h View 3 chunks +20 lines, -7 lines 0 comments Download
M trunk/public/platform/WebCryptoKeyAlgorithm.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/public/platform/WebCryptoKeyAlgorithmParams.h View 4 chunks +21 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-23 23:38:07 UTC) #1
Ken Russell (switch to Gerrit)
Committed patchset #1 manually as r174733.
6 years, 7 months ago (2014-05-23 23:38:19 UTC) #2
eroman
6 years, 7 months ago (2014-05-23 23:59:52 UTC) #3
Message was sent while issue was closed.
Thank you Ken!

(I believe that "maybe-uninitilized" warning is bogus. I'll add a workaround and
try re-submitting later.)

LGTM

Powered by Google App Engine
This is Rietveld 408576698