Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: pkg/telemetry/lib/crash_reporting.dart

Issue 2963323002: Add analytics to analyzer-cli and analysis server. (Closed)
Patch Set: update from review comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/telemetry/BUILD.gn ('k') | pkg/telemetry/lib/telemetry.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/telemetry/lib/crash_reporting.dart
diff --git a/pkg/telemetry/lib/crash_reporting.dart b/pkg/telemetry/lib/crash_reporting.dart
index 37d6b755949198f8ec031b7bb89affbb5441f16d..c34766eb0b8b0ed4984475c0fd08ea4a745e30c5 100644
--- a/pkg/telemetry/lib/crash_reporting.dart
+++ b/pkg/telemetry/lib/crash_reporting.dart
@@ -32,12 +32,14 @@ class CrashReportSender {
static final Uri _baseUri = new Uri(
scheme: 'https', host: _crashServerHost, path: _crashEndpointPath);
+ final String crashProductId;
final Analytics analytics;
final http.Client _httpClient;
/// Create a new [CrashReportSender], using the data from the given
/// [Analytics] instance.
- CrashReportSender(this.analytics, {http.Client httpClient})
+ CrashReportSender(this.crashProductId, this.analytics,
+ {http.Client httpClient})
: _httpClient = httpClient ?? new http.Client();
/// Sends one crash report.
@@ -58,7 +60,7 @@ class CrashReportSender {
final http.MultipartRequest req = new http.MultipartRequest('POST', uri);
req.fields['uuid'] = analytics.clientId;
- req.fields['product'] = analytics.trackingId;
+ req.fields['product'] = crashProductId;
req.fields['version'] = analytics.applicationVersion;
req.fields['osName'] = Platform.operatingSystem;
// TODO(devoncarew): Report the operating system version when we're able.
« no previous file with comments | « pkg/telemetry/BUILD.gn ('k') | pkg/telemetry/lib/telemetry.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698