Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: pkg/analysis_server/test/integration/support/integration_tests.dart

Issue 2963323002: Add analytics to analyzer-cli and analysis server. (Closed)
Patch Set: update from review comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/domain_server_test.dart ('k') | pkg/analyzer_cli/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/integration/support/integration_tests.dart
diff --git a/pkg/analysis_server/test/integration/support/integration_tests.dart b/pkg/analysis_server/test/integration/support/integration_tests.dart
index 1ce540c7ba2cdada86bd0ad59c940bae99007253..972e27ee2c49eed7d91eeeeb5fa9535b9293b0d6 100644
--- a/pkg/analysis_server/test/integration/support/integration_tests.dart
+++ b/pkg/analysis_server/test/integration/support/integration_tests.dart
@@ -694,6 +694,7 @@ class Server {
//
// Add server arguments.
//
+ arguments.add('--suppress-analytics');
if (diagnosticPort != null) {
arguments.add('--port');
arguments.add(diagnosticPort.toString());
@@ -707,11 +708,9 @@ class Server {
if (useAnalysisHighlight2) {
arguments.add('--useAnalysisHighlight2');
}
-// print('Launching $serverPath');
-// print('$dartBinary ${arguments.join(' ')}');
// TODO(devoncarew): We could experiment with instead launching the analysis
// server in a separate isolate. This would make it easier to debug the
- // integration tests, and would likely speed the tests up as well.
+ // integration tests, and would likely speed up the tests as well.
_process = await Process.start(dartBinary, arguments);
_process.exitCode.then((int code) {
if (code != 0) {
« no previous file with comments | « pkg/analysis_server/test/domain_server_test.dart ('k') | pkg/analyzer_cli/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698