Add analytics to analyzer-cli and analysis server.

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:core';
 import 'dart:io' as io;
 import 'dart:math' show max;
 
@@ skipping 43 matching lines @@
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/source_io.dart';
 import 'package:analyzer/src/generated/utilities_general.dart';
 import 'package:analyzer/src/util/glob.dart';
 import 'package:analyzer_plugin/protocol/protocol_common.dart' hide Element;
 import 'package:front_end/src/base/performace_logger.dart';
 import 'package:front_end/src/incremental/byte_store.dart';
 import 'package:front_end/src/incremental/file_byte_store.dart';
 import 'package:plugin/plugin.dart';
+import 'package:telemetry/crash_reporting.dart';
+import 'package:telemetry/telemetry.dart' as telemetry;
+import 'package:usage/usage.dart';
 import 'package:watcher/watcher.dart';
 
 typedef void OptionUpdater(AnalysisOptionsImpl options);
 
 /**
  * Enum representing reasons why analysis might be done for a given file.
  */
 class AnalysisDoneReason {
   /**
    * Analysis of the file completed successfully.
@@ skipping 697 matching lines @@
       stackTrace = StackTrace.current;
       buffer.writeln();
       buffer.write(stackTrace);
     }
 
     // send the notification
     channel.sendNotification(
         new ServerErrorParams(fatal, message, buffer.toString())
             .toNotification());
 
+    // send to crash reporting
+    options.crashReportSender.sendReport(exception, stackTrace: stackTrace);
+
     // remember the last few exceptions
     if (exception is CaughtException) {
       stackTrace ??= exception.stackTrace;
     }
     exceptions.add(new ServerException(message, exception, stackTrace, fatal));
   }
 
   /**
    * Send status notification to the client. The state of analysis is given by
    * the [status] information.
@@ skipping 106 matching lines @@
   }
 
   /**
    * Returns `true` if errors should be reported for [file] with the given
    * absolute path.
    */
   bool shouldSendErrorsNotificationFor(String file) {
     return contextManager.isInAnalysisRoot(file);
   }
 
-  void shutdown() {
+  Future shutdown() async {

[scheglov, 2017/06/30 23:36:29]

Future<Null>

[devoncarew, 2017/07/01 22:18:04]

Done.

     running = false;
     // Defer closing the channel and shutting down the instrumentation server so
     // that the shutdown response can be sent and logged.
-    new Future(() {
+    await new Future(() {

[Brian Wilkerson, 2017/06/30 22:52:17]

We don't currently wait. Are you sure we should?

[devoncarew, 2017/07/01 22:18:04]

I've removed the await (and added the ability to close any active analytics
requests).

       instrumentationService.shutdown();
       channel.close();
     });
+
+    // TODO(devoncarew): Call exit() explicitly?
+    await options.analytics
+        .waitForLastPing(timeout: new Duration(milliseconds: 200));
   }
 
   /**
    * Implementation for `analysis.updateContent`.
    */
   void updateContent(String id, Map<String, dynamic> changes) {
     changes.forEach((file, change) {
       // Prepare the new contents.
       String oldContents = fileContentOverlay[file];
       String newContents;
@@ skipping 119 matching lines @@
 }
 
 class AnalysisServerOptions {
   bool useAnalysisHighlight2 = false;
   String fileReadMode = 'as-is';
   String newAnalysisDriverLog;
 
   String clientId;
   String clientVersion;
 
+  telemetry.Analytics analytics;
+  CrashReportSender crashReportSender;
+
   // IDE options
   bool enableVerboseFlutterCompletions = false;
+
+  void addMocks() {

[scheglov, 2017/06/30 23:36:29]

Do we create and assign these objects just to avoid checks for null?
Why not create them in constructor to avoid requirement for every client to call
addMocks()?

[devoncarew, 2017/07/01 22:18:04]

I removed this method, and instead had all the places that dereference the
analytics or crashReportSender objects use null aware operators (and added some
dartdoc for those fields). 

+    analytics = new AnalyticsMock()..enabled = false;
+    crashReportSender = new CrashReportSender('mock-crash-id', analytics);
+  }
 }
 
 /**
  * A [PriorityChangeEvent] indicates the set the priority files has changed.
  */
 class PriorityChangeEvent {
   final Source firstSource;
 
   PriorityChangeEvent(this.firstSource);
 }
@@ skipping 399 matching lines @@
   /**
    * The [PerformanceTag] for time spent in server request handlers.
    */
   static PerformanceTag serverRequests = server.createChild('requests');
 
   /**
    * The [PerformanceTag] for time spent in split store microtasks.
    */
   static PerformanceTag splitStore = new PerformanceTag('splitStore');
 }