Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2963313002: Stop using ExecutableElement.localVariables in inference tests. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop using ExecutableElement.localVariables in inference tests. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/aecef975c93b9af47f79ffd45cc2fe03038d20b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -155 lines) Patch
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 70 chunks +142 lines, -155 lines 0 comments Download
M pkg/analyzer/test/utils.dart View 3 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-06-30 16:52:17 UTC) #1
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-06-30 17:03:07 UTC) #2
scheglov
3 years, 5 months ago (2017-06-30 17:30:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aecef975c93b9af47f79ffd45cc2fe03038d20b3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698